Codecov Report

Merging #1444 into master will decrease coverage by 0.47%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   87.29%   86.82%   -0.48%     
==========================================
  Files          25       25              
  Lines        5406     5448      +42     
==========================================
+ Hits         4719     4730      +11     
- Misses        687      718      +31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f97b18...ba75cc4. Read the comment docs.

Ok, this is no longer WIP: it works and https://pkg.julialang.org is currently working as a Pkg Server. Any thoughts on what the next steps here ought to be? This doesn't currently have tests, which I don't love, but it's also a bit hard to test locally and we weren't really explicitly testing installing packages from GitHub previously anyway, so maybe the implicit testing of installing packages is sufficient. I'd like to merge this to master on Pkg and then bump the version of Pkg that Julia master is using so that we get people who use Julia master to test this out.

Oh, the main drawback that this currently has is that it does not do diffs for updates, which means that when you update the registry, you have to download a whole new compressed registry tarball. I'm working on diffs, but it's a bit tricky, so I'd like to get this out there into people's hands first.

MethodError: no method matching pkg_server_registry_url(::Nothing) on CI.

Ok, this is no longer WIP: it works and https://pkg.julialang.org is currently working as a Pkg Server.

Seems to be somewhat out of sync with the new releases to the registry, couldn't install the most recent version of some packages.

Is the server spec documented somewhere? Is it basically following #1377 (comment) ?

which means that when you update the registry, you have to download a whole new compressed registry tarball.

This does not seem to happen? Since you just get a snapshot of the registry I don't think it will be updated, since we only update registries that are git repos.

Edit: Nvm, Just that pkg.julialang.org does not sync with JuliaRegistries/General.

Lots of

Warning: could not download https://pkg.julialang.org/registries

so something seems to be off. Maybe because we do some trickery in order to not update the registry all the time on CI? E.g. in

Any idea why the CI process would be unable to reach https://pkg.julialang.org/registries?

I've made it opt-in now by setting JULIA_PKG_SERVER=pkg.julialang.org in the environment. Given that it's opt in and works locally and the server is correctly updating now, I think that we can probably merge this if CI passes. There will probably be a few changes before 1.4 feature freeze, including the ability to update things with diffs, and the ability to inject authentication headers, but it would be good to get some testing of this on master, even opted out, in the mean time.

I've attempted to fix the merge conflict, if it goes through, let's merge.

needs updating to the new signature (https://ci.appveyor.com/project/ararslan/primes-jl/builds/29199679/job/6ff0p4f64rxbqk6b)